Skip to content

Document modal that dismisses by gesture only when ScrollView is at top #333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

0xRAG
Copy link
Contributor

@0xRAG 0xRAG commented Dec 30, 2018

This fixes #315!

Any and all feedback is welcome :)

@react-navigation-bot
Copy link

Deploy preview for react-navigation ready!

Built with commit c3cf6d3

https://deploy-preview-333--react-navigation.netlify.com

@brentvatne
Copy link
Member

Thanks for this! Love the writing style.

@0xRAG
Copy link
Contributor Author

0xRAG commented Dec 31, 2018

Oh man, I initially didn't notice the delay, but now that you point it out it's awful! You're right, we can do better. I'll take a look at that TransparentStack!

Thanks for the feedback :)

@jfrolich
Copy link

Hmm any pointers how to build this interaction? This proposed solution doesn't really work every time. This would be nice to document, as a scrollable + modal is a pretty common use case, and it seems to be possible now that RN3.0 uses react-native-gesture-handler. I don't really know where to start however.

@0xRAG 0xRAG closed this May 17, 2019
@zeh
Copy link

zeh commented Sep 25, 2019

@jfrolich Ditto. @ryan-gilb did you manage to ever fix the issue where pressing down sometimes works (starting the modal close gestures), sometimes doesn't (still pulling from the scrollview)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document how to build a modal that dismisses by gesture only when ScrollView is at top
5 participants